Issue 1673: modifications in safe_sleep function#1674
Issue 1673: modifications in safe_sleep function#1674ruvceskistefan wants to merge 3 commits intoactions:mainfrom ruvceskistefan:stefan-ruvceski/bug/1673
Conversation
|
the PR is somewhat okay... i just want to specify something: the reason i used the That being said... You should instead reset the As i said, also, having the rest of the code in there becomes rather useless since the
also... it would be a good habbit to comment unusual code like Enjoy |
|
Thanks for the reply, I replaced the |
|
@ruvceskistefan Regarding launching the runner using, say, Meaning, don't we already have a dependency on bash here? That would suggest to me $SECONDS is fine. |
|
@fhammerl I think you're right, then I'll get the unnecessary code out of |
|
Approved! @ruvceskistefan if you're up for some follow-up, it may be worth looking into other usages of |
|
Thanks @fhammerl! Of course, I'll move on that after I solve the priority issues. |
Problem was the implementation of sleep in the case when both ping and sleep are missing in safe_sleep function.
Related issue: #1673
After this change, the problem described in the related issue has been fixed.